Skip to content

Update farcaster client max cast length#1347

Merged
mcp97 merged 3 commits into
elizaOS:developfrom
0x330a:main
Dec 21, 2024
Merged

Update farcaster client max cast length#1347
mcp97 merged 3 commits into
elizaOS:developfrom
0x330a:main

Conversation

@0x330a
Copy link
Copy Markdown
Contributor

@0x330a 0x330a commented Dec 21, 2024

Risks

Medium risk: I don't know if neynar's APIs support long casts with 1024 length without any additional flags as I couldn't find the limit documented or if there are any other parameters except for text in their publishCast function. I don't have an account to test it. The value takes into consideration the byte length of the cast, so maybe unicode characters of 1024 length will fail.

Background

What does this PR do?

What kind of change is this?

The cast limit for farcaster client has been modified to match the protocol's spec

Why are we doing this? Any context or related work?

I wanted it to match the spec instead of the currently incorrectly defined limit

Documentation changes needed?

I don't think there's any documentation for the Farcaster client at the moment

Testing

Where should a reviewer start?

If you have a neynar account try posting a cast with a message size of 1024 bytes

@0x330a 0x330a changed the base branch from main to develop December 21, 2024 23:30
Copy link
Copy Markdown
Contributor

@mcp97 mcp97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcp97 mcp97 merged commit b9d819e into elizaOS:develop Dec 21, 2024
lalalune pushed a commit that referenced this pull request May 3, 2026
Update farcaster client max cast length
FranceFlapjack pushed a commit to FranceFlapjack/eliza that referenced this pull request May 16, 2026
Update farcaster client max cast length
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants