fix: duplicate tweet log#1402
Merged
Merged
Conversation
- Resolved an issue where `generateNewTweetLoop` was called twice in the `start` method of /packages/client-twitter/src/post.ts.\n- The method was invoked at line 174 and line 190 without any conditional checks, leading to two independent tweet scheduling loops being created.\n- Removed one of the redundant `generateNewTweetLoop` calls to ensure only a single scheduling loop is initialized.\n\nFixes elizaOS#1395
Contributor
Author
|
The PR I previously created has been closed, which was incorrect. I have created a new PR to merge into the develop branch. |
mcp97
approved these changes
Dec 23, 2024
1to3for5vi7ate9x
pushed a commit
to 1to3for5vi7ate9x/eliza
that referenced
this pull request
Jan 26, 2025
…weet-log fix: duplicate tweet log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generateNewTweetLoopwas called twice in thestartmethod of /packages/client-twitter/src/post.ts.generateNewTweetLoop()inside theif (enableActionProcessing)Fixes #1395
Relates to:
Issue #1395
Risks
Low: Removing the redundant call ensures only one scheduling loop, minimal impact on other functionalities.
Background
What does this PR do?
This PR fixes an issue where
generateNewTweetLoopwas called twice, leading multiple tweets to be posted. It ensures only a single scheduling loop is initialized by removing the redundant call.What kind of change is this?
Bug fixes (non-breaking change which fixes an issue)
Documentation changes needed?
My changes do not require a change to the project documentation.
Testing
Where should a reviewer start?
Start by reviewing the
startmethod in /packages/client-twitter/src/post.ts, focusing on the moving secondgenerateNewTweetLoop()inside theif (enableActionProcessing)condition.Detailed testing steps
POST_IMMEDIATELY=trueto enable immediate tweet posting.Next tweet scheduled in xxx minutesmessages.Next tweet scheduled in xxx minutesmessage is logged only once.