Skip to content

fix: add required incremental option and remove invalid typescript configuration#1485

Merged
mcp97 merged 4 commits into
elizaOS:developfrom
Shane0xM:fix/typescript-config
Dec 28, 2024
Merged

fix: add required incremental option and remove invalid typescript configuration#1485
mcp97 merged 4 commits into
elizaOS:developfrom
Shane0xM:fix/typescript-config

Conversation

@Shane0xM
Copy link
Copy Markdown
Contributor

@Shane0xM Shane0xM commented Dec 27, 2024

Relates to:

No specific issue ticket - fixing TypeScript configuration errors encountered during build

Risks

Low - Configuration changes only, no functional code changes

  • Affects TypeScript compilation settings
  • No runtime behavior changes
  • Only impacts development/build time performance

Background

What does this PR do?

Fixes two TypeScript configuration issues:

  1. Adds required incremental option for tsBuildInfoFile usage
  • 'tsBuildInfoFile' is used for incremental compilation but requires 'incremental: true'
  • This change will improve build performance by enabling proper incremental builds
  1. Removes invalid compiler option noUncheckedSideEffectImports
  • This option is not a valid TypeScript compiler option
  • Removing it resolves the TypeScript configuration error

These changes resolve the following errors:

Option 'tsBuildInfoFile' cannot be specified without specifying option 'incremental'
Unknown compiler option 'noUncheckedSideEffectImports'

What kind of change is this?

Bug fixes (non-breaking change which fixes an issue)

  • Improves TypeScript configuration
  • Enables proper incremental builds
  • Removes invalid configuration option

Documentation changes needed?

My changes do not require a change to the project documentation as they only affect internal TypeScript configuration.

Testing

Where should a reviewer start?

Review the changes in:

  1. client/tsconfig.app.json
  2. client/tsconfig.node.json

Detailed testing steps

  1. Clone the repository and checkout this branch
  2. Install dependencies:
cd client
pnpm install
  1. Run TypeScript compilation to verify errors are resolved:
pnpm check-types
  1. Verify no TypeScript configuration errors are reported
  2. Run the development server to ensure everything works:
pnpm dev

Deploy Notes

No special deploy steps required - changes only affect development/build configuration

  • Build performance may improve due to proper incremental compilation
  • No runtime changes or dependencies affected

@mcp97 mcp97 changed the base branch from main to develop December 27, 2024 02:08
Copy link
Copy Markdown
Contributor

@mcp97 mcp97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@mcp97 mcp97 merged commit 2633a5e into elizaOS:develop Dec 28, 2024
lalalune pushed a commit that referenced this pull request May 3, 2026
fix: add required incremental option and remove invalid typescript configuration
FranceFlapjack pushed a commit to FranceFlapjack/eliza that referenced this pull request May 16, 2026
fix: add required incremental option and remove invalid typescript configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants