Skip to content

feat: Starknet plugin#287

Merged
lalalune merged 7 commits into
mainfrom
starknet-plugin
Nov 15, 2024
Merged

feat: Starknet plugin#287
lalalune merged 7 commits into
mainfrom
starknet-plugin

Conversation

@ponderingdemocritus
Copy link
Copy Markdown
Contributor

@ponderingdemocritus ponderingdemocritus commented Nov 13, 2024

  • PR turned into type and import cleanup. Conflicts were happening between bundled and non-bundled types. This is now resolved
  • Implements scaffold for Starknet plugin that allows swapping.
  • adds pr title workflow - for sanity and cleanliness

After building and tests, lets merge to keep head clean, then will keep iterating on SN plugin

@ponderingdemocritus ponderingdemocritus marked this pull request as ready for review November 15, 2024 23:12
@lalalune lalalune merged commit 8fe9cb5 into main Nov 15, 2024
@lalalune lalalune deleted the starknet-plugin branch November 15, 2024 23:23
@sirkitree
Copy link
Copy Markdown
Contributor

This seems to have removed all tests. Is there a plan for adding them back? If we want to get into a reliable release path we should have proper test coverage.

lalalune added a commit that referenced this pull request May 3, 2026
FranceFlapjack pushed a commit to FranceFlapjack/eliza that referenced this pull request May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants