feat: add ICP token creation support#357
Merged
Merged
Conversation
- Add plugin-icp to enable token creation on Pickpump platform - Implement createToken functionality for Internet Computer Protocol (ICP) - Support ICP token standard and specifications - Enable seamless integration with Pickpump's token creation flow BREAKING CHANGE: None
Member
|
this is fucking rad, will review later |
mcp97
reviewed
Nov 18, 2024
| import { unwrapRustResultMap } from "../utils/common/types/results"; | ||
| import { icpWalletProvider } from "../providers/wallet"; | ||
|
|
||
| const createTokenTemplate = `Respond with a JSON markdown block containing only the extracted values. Use null for any values that cannot be determined. |
Contributor
There was a problem hiding this comment.
Can we move this into a templates file for readability? Thanks so much!
mcp97
reviewed
Nov 18, 2024
| ): Promise<any> { | ||
| const actor: _SERVICE = await creator( | ||
| idlFactory, | ||
| "bn4fo-iyaaa-aaaap-akp6a-cai" |
Contributor
There was a problem hiding this comment.
Can this be moved to a constants file?
mcp97
reviewed
Nov 18, 2024
| name: tokenInfo.name ?? "My ICP Token", | ||
| symbol: tokenInfo.symbol ?? "MIT", | ||
| description: tokenInfo.description ?? "A fun meme token on ICP", | ||
| logo: "https://icptoken.default.logo", |
mcp97
reviewed
Nov 18, 2024
| modelClass: ModelClass.LARGE, | ||
| }); | ||
|
|
||
| console.log("Response:", response); |
mcp97
reviewed
Nov 18, 2024
| telegram: response.telegram, | ||
| }); | ||
|
|
||
| console.log("Token created successfully:", createTokenResult); |
mcp97
reviewed
Nov 18, 2024
| import type { Principal } from "@dfinity/principal"; | ||
| import type { ActorSubclass } from "@dfinity/agent"; | ||
| import type { IDL } from "@dfinity/candid"; | ||
| export interface ICPConfig { |
mcp97
reviewed
Nov 18, 2024
| export const customStringify = (v: any): string => | ||
| JSON.stringify(v, (_key, value) => { | ||
| if (typeof value === "bigint") return `${value}`; | ||
| if (value && typeof value === "object" && value._isPrincipal === true) { |
Contributor
There was a problem hiding this comment.
For readability: else if probably more appropriate
mcp97
reviewed
Nov 19, 2024
| export const handleShowPrice = (value: number | string, fixed = 8) => { | ||
| if (!value || value === "0") return 0; | ||
| return _.round(Number(value), fixed); | ||
| // return value / 1e18; |
mcp97
reviewed
Nov 19, 2024
| @@ -0,0 +1,21 @@ | |||
| // hex text -> number array | |||
Contributor
There was a problem hiding this comment.
We could consider moving this to the array utils as they are all related to arrays
mcp97
reviewed
Nov 19, 2024
| import { string2array } from "../arrays"; | ||
|
|
||
| // Principal -> string | ||
| export const principal2string = (p: Principal): string => p.toText(); |
Contributor
There was a problem hiding this comment.
Can remove and use util for these
mcp97
suggested changes
Nov 19, 2024
Contributor
mcp97
left a comment
mcp97
left a comment
There was a problem hiding this comment.
This is some amazing work - thank you for working on this! Added a handful of small nits feel free to address and we are good to go!
Contributor
|
Also feel free to fix the PR Title check, add in a a screen grab of successful token creation, and consider an integration test to simulate the entire token creation flow using mocks or a test canister to ensure the plugin works end-to-end. Also can we update the plugin associated READMEs so it is easier to leverage. Thanks so much! So sorry for all the comments! You are a badass and did some great work here! |
Contributor
Author
|
Thank u for ur review, I will fix the issues. @monilpat |
|
Oh yeah |
asDNSk
changed the title
lalalune
added a commit
that referenced
this pull request
Dec 1, 2024
fix: follow-up improvements for ICP token creation (PR #357)
lalalune
added a commit
that referenced
this pull request
May 3, 2026
fix: follow-up improvements for ICP token creation (PR #357)
FranceFlapjack
pushed a commit
to FranceFlapjack/eliza
that referenced
this pull request
May 16, 2026
fix: follow-up improvements for ICP token creation (PR elizaOS#357)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: None