Register memory managers if passed to runtime#396
Merged
lalalune merged 1 commit intoNov 18, 2024
Merged
Conversation
Member
|
Good idea |
lalalune
added a commit
that referenced
this pull request
May 3, 2026
…f-runtime-passed-to-contructor Register memory managers if passed to runtime
FranceFlapjack
pushed a commit
to FranceFlapjack/eliza
that referenced
this pull request
May 16, 2026
…agers-of-runtime-passed-to-contructor Register memory managers if passed to runtime
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to:
Risks
Low. This change introduces a new feature to register memory managers, which should not affect existing functionality.
Background
What does this PR do?
This PR adds functionality to register memory managers if they are passed to the runtime. It iterates through the
managersarray in theoptsobject and callsregisterMemoryManagerfor each manager.What kind of change is this?
Features (non-breaking change which adds functionality)
Documentation changes needed?
My changes do not require a change to the project documentation.
Testing
Where should a reviewer start?
The reviewer should start by examining the
AgentRuntimeclass in thepackages/core/src/runtime.tsfile, focusing on the new code block that registers memory managers.Detailed testing steps
AgentRuntimeclass correctly initializes with the new code block.registerMemoryManagermethod is called for each manager in the array.Deploy Notes
No special deploy notes are required for this change.
Sources