feat: services#412
Merged
Merged
Conversation
mcp97
suggested changes
Nov 19, 2024
Contributor
mcp97
left a comment
mcp97
left a comment
There was a problem hiding this comment.
Great job with this feature! Thanks for getting this out! LGTM outside of addressing comments :)
Contributor
|
Great work here! Feel free to a quick TLDR using the PR template if you can on the issue and any testing plan thank you so much! |
Contributor
Author
|
found some issues still - working on them |
FranceFlapjack
pushed a commit
to FranceFlapjack/eliza
that referenced
this pull request
May 16, 2026
feat: services
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug within the services singelton pattern that cause the incorrect serivce to be called when multiple ones were used.
This changes the architecture so this doesn't happen.