Skip to content

ollama generate case was using console.debug. #474

Merged
lalalune merged 1 commit into
elizaOS:mainfrom
drew-royster:fix/ollama-generation-use-eliza-logger
Nov 21, 2024
Merged

ollama generate case was using console.debug. #474
lalalune merged 1 commit into
elizaOS:mainfrom
drew-royster:fix/ollama-generation-use-eliza-logger

Conversation

@drew-royster
Copy link
Copy Markdown
Contributor

Relates to:

#443

Risks

Low: almost none, just switching to the correct logger.

Background

Using ollama appeared chattier than other providers which is why the bug was reported, but that seems to be just because the wrong logger was used accidentally

What does this PR do?

switch to elizaLogger

What kind of change is this?

Bug fixes (non-breaking change which fixes an issue)

Documentation changes needed?

No

Testing

Ran against my ollama to repro bug

modelClass small
Initializing Ollama model.
****** MODEL
 llama3.2
Received response from Ollama model.
Initializing Ollama model.
****** MODEL
 llama3.2
Received response from Ollama model.
Initializing Ollama model.
****** MODEL
 llama3.2
Received response from Ollama model.
Initializing Ollama model.
****** MODEL
 llama3.2
Received response from Ollama model.

changed offending lines in node_modules/ai16z/eliza/dist/index.js

No more chatty messages

hi there
 ◎ LOGS
   Evaluating 
   GET_FACTS 

 ◎ LOGS
   Evaluating 
   UPDATE_GOAL 

 ["✓ Normalized action: continue"] 

 ["✓ Executing handler for action: CONTINUE"] 

modelClass small
Agent: Thanks for reaching out! I'd be happy to help with your tax questions. Can you please tell me a bit more about what's going on and what you're hoping to achieve? Is it related to deductions, exemptions, or something else?
Agent: TAXES, A CRUCIAL TOPIC! UNDER MY ADMINISTRATION, WE CUT TAXES FOR THE MIDDLE CLASS AND BOOSTED THE ECONOMY! NOW, WITH THE DEMOCRATS IN CONTROL, THEY'RE TRYING TO INCREASE TAXES AND HURT AMERICAN FAMILIES. WHAT SPECIFICALLY DO YOU NEED HELP WITH? LET'S WORK TOGETHER TO BRING BACK THE SUCCESS WE ONCE HAD!
You: hello

Where should a reviewer start?

Run it without my changes with ollama and then run it with, very targeted fix

Discord username

droyster

@lalalune lalalune merged commit 9bd13c6 into elizaOS:main Nov 21, 2024
lalalune added a commit that referenced this pull request May 3, 2026
…liza-logger

ollama generate case was using console.debug.
FranceFlapjack pushed a commit to FranceFlapjack/eliza that referenced this pull request May 16, 2026
…n-use-eliza-logger

ollama generate case was using console.debug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants