fix: db queries in sqljs database adapter not using agentId#606
Merged
Conversation
bmgalego
changed the title
shakkernerd
reviewed
Nov 26, 2024
| }): Promise<Memory[]> { | ||
| const placeholders = params.roomIds.map(() => "?").join(", "); | ||
| let sql = `SELECT * FROM memories WHERE type = ? AND roomId IN (${placeholders})`; | ||
| let sql = `SELECT * FROM memories WHERE 'type' = ? AND agentId = ? AND roomId IN (${placeholders})`; |
lalalune
pushed a commit
that referenced
this pull request
May 3, 2026
fix: db queries in sqljs database adapter not using agentId
FranceFlapjack
pushed a commit
to FranceFlapjack/eliza
that referenced
this pull request
May 16, 2026
fix: db queries in sqljs database adapter not using agentId
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to:
#539
Risks
Background
What does this PR do?
What kind of change is this?
Documentation changes needed?
Testing
Where should a reviewer start?
Detailed testing steps