feat: (voice) enhance character card voice configuration support#698
Merged
Conversation
augchan42
changed the title
Contributor
Author
|
BTW this PR also fixes the web-agent/vite build issues |
Contributor
This is already fixed on recent main. |
Contributor
|
Can you start by resolving the conflicts and why are there so many changed files? It says 141 files right now. |
Contributor
Author
|
The changed files are autogenearated docs from the build process. I'll
take a look
…On Sat, Nov 30, 2024 at 3:11 PM Shakker Nerd ***@***.***> wrote:
Can you start by resolving the conflicts and why are there so many changed
files? It says 141 files right now.
—
Reply to this email directly, view it on GitHub
<#698 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE32LKN2RGJTZQRWHPCTD3L2DFQILAVCNFSM6AAAAABSYBSAV2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBYHA3DMNBSHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
- Add comprehensive ElevenLabs configuration in character cards
- Make ElevenLabs settings optional with sensible defaults
- Implement configuration priority (character card > env vars > defaults)
- Update schema validation to support optional fields
- Add debug logging for voice selection process
- Maintain backward compatibility with existing setups
Example character card config:
```json
{
"settings": {
"voice": {
"model": "en_GB-alan-medium",
"elevenlabs": {
"voiceId": "your-voice-id",
"model": "eleven_monolingual_v1",
"stability": "0.5"
}
}
}
}
```
Closes #694
augchan42
force-pushed
the
fix/character-voice-settings
branch
from
d2690af to
607daa9
Compare
Contributor
Author
|
From 141 files to 8, I re-ran the build and it works after removing the web-agent folder (had to fix target in package.json) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(voice): enhance character card voice configuration support
Example character card config:
{ "settings": { "voice": { "model": "en_GB-alan-medium", "elevenlabs": { "voiceId": "your-voice-id", "model": "eleven_monolingual_v1", "stability": "0.5" } } } }Closes #694