fix: Use LARGE models for responses#853
Merged
Merged
Conversation
mcp97
approved these changes
Dec 5, 2024
mcp97
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks so much for doing this :) Was always confused by this lol - appreciate the fix!
jkbrooks
approved these changes
Dec 5, 2024
dsldsl
pushed a commit
to dsldsl/eliza
that referenced
this pull request
Dec 7, 2024
fix: Use LARGE models for responses
Kevin-Mok
pushed a commit
to Kevin-Mok/eliza
that referenced
this pull request
Dec 11, 2024
|
Why hardcode any values? Hardcoding makes the model settings very limited and forces developers to fork the library just to use a different model. Allowing them to be set in the character file is much more useful. This is what the character file model settings used to look like: This PR allows this much more flexible approach: |
lalalune
pushed a commit
that referenced
this pull request
May 3, 2026
fix: Use LARGE models for responses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the small models big. Apparently we've been using small models for interactions and message responses, but this is wrong.