Skip to content

Remove duplicated coinbase CDP options in .env.example#863

Merged
jkbrooks merged 1 commit into
elizaOS:mainfrom
juntao:patch-1
Dec 6, 2024
Merged

Remove duplicated coinbase CDP options in .env.example#863
jkbrooks merged 1 commit into
elizaOS:mainfrom
juntao:patch-1

Conversation

@juntao
Copy link
Copy Markdown
Contributor

@juntao juntao commented Dec 5, 2024

The removed section is identical to the section above it.

Relates to:

Risks

Low

Background

What does this PR do?

It removes a duplicated section in the .env.example file.

What kind of change is this?

Bug fixes (non-breaking change which fixes an issue)

Why are we doing this? Any context or related work?

I believe the duplicated section is a bug. If the two sections are set to different values, it could really confuse people.

Documentation changes needed?

My changes do not require a change to the project documentation.

Testing

Where should a reviewer start?

Simple change to the example configuration.

Detailed testing steps

None, automated tests are fine.

Discord username

juntaoyuan

The removed section is identical to the section above it.
Copy link
Copy Markdown
Contributor

@mcp97 mcp97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jkbrooks jkbrooks merged commit 7fb73d2 into elizaOS:main Dec 6, 2024
@juntao juntao deleted the patch-1 branch December 6, 2024 04:54
dsldsl pushed a commit to dsldsl/eliza that referenced this pull request Dec 7, 2024
Remove duplicated coinbase CDP options in .env.example
lalalune pushed a commit that referenced this pull request May 3, 2026
Remove duplicated coinbase CDP options in .env.example
FranceFlapjack pushed a commit to FranceFlapjack/eliza that referenced this pull request May 16, 2026
Remove duplicated coinbase CDP options in .env.example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants