Skip to content

move ember debug tests into own app #2642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

patricklx
Copy link
Collaborator

@patricklx patricklx commented May 21, 2025

ember debug is the thing that should/can be tested with older ember versions.
for inspector ui its not required. we can extend it for it as well though.

test fixed by mostly using setComponentTemplate as dynamic template resolving has been deprecated

This also

  • adds back support for ember alpha+, ember/index has been removed and we have ember/barrel now
  • fixes some InElement support issues with ember 6.4

@patricklx patricklx force-pushed the split-out-ember-debug-tests branch from ea8f7dd to c38d0f0 Compare May 22, 2025 08:24
@patricklx patricklx requested a review from RobbieTheWagner May 22, 2025 11:24
@BlueCutOfficial
Copy link
Contributor

Since this PR changes the usage of ember-try in the repo, I would be tempted to add ember-lts-5.12 to the configuration (and it's green locally ✅) IMO that could be a good iteration before investigating 6.x in a later PR :)

@patricklx patricklx force-pushed the split-out-ember-debug-tests branch 4 times, most recently from 1df0de2 to 24127a0 Compare May 30, 2025 20:48
@patricklx patricklx closed this May 31, 2025
@patricklx patricklx reopened this May 31, 2025
@patricklx patricklx force-pushed the split-out-ember-debug-tests branch from ed1d1b6 to f15771c Compare June 1, 2025 15:39
@patricklx patricklx closed this Jun 1, 2025
@patricklx patricklx reopened this Jun 1, 2025
@patricklx patricklx force-pushed the split-out-ember-debug-tests branch from ae33cb7 to b085545 Compare June 1, 2025 16:44
<script src="{{rootURL}}assets/vendor.js"></script>
<script src="{{rootURL}}assets/test-support.js"></script>
<script src="{{rootURL}}assets/test-app.js"></script>
<script src="{{rootURL}}ember_debug.js"></script>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here we inject ember debug into the test app

@patricklx patricklx force-pushed the split-out-ember-debug-tests branch 4 times, most recently from de7b45d to c238b51 Compare June 2, 2025 08:08
@patricklx patricklx changed the title move ember debug tests into own app move ember debug tests into own app & fix tests Jun 2, 2025
@patricklx patricklx force-pushed the split-out-ember-debug-tests branch 2 times, most recently from 7d97550 to 2bf5316 Compare June 3, 2025 10:08
Copy link
Contributor

@BlueCutOfficial BlueCutOfficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be fair I don't understand 100% all the details of all the changes so I would use at least one second opinion (cc @mansona) but this iteration looks fine IMO. The general approach to separate UI tests and ember_debug tests makes sense to me + fixing all the ember-try scenarios recreates more confidence in the test suite.

(Purely on the form, I think enabling 6+ and fixing 3.16~3.24 could have been done in 2 separated PRs, but I woundn't consider this a blocker since the commit stack is clean)

@patricklx patricklx requested a review from mansona June 4, 2025 07:38
@patricklx patricklx force-pushed the split-out-ember-debug-tests branch 4 times, most recently from 6279974 to 8eac3ce Compare June 4, 2025 10:24
@patricklx patricklx closed this Jun 17, 2025
@patricklx patricklx reopened this Jun 24, 2025
@patricklx patricklx force-pushed the split-out-ember-debug-tests branch 5 times, most recently from 985be8c to 77df22c Compare June 24, 2025 20:01
@patricklx patricklx changed the title move ember debug tests into own app & fix tests move ember debug tests into own app Jun 24, 2025
@patricklx patricklx force-pushed the split-out-ember-debug-tests branch 10 times, most recently from 8be8b8b to 6659f91 Compare June 25, 2025 07:29
@BlueCutOfficial BlueCutOfficial self-requested a review June 25, 2025 07:37
@patricklx patricklx force-pushed the split-out-ember-debug-tests branch from 6659f91 to 850d0a8 Compare June 25, 2025 07:37
@BlueCutOfficial
Copy link
Contributor

Hi @patricklx, I've an update about this PR.

@mansona has initiated a task to improve the "start wrapper" part of the inspector, based on his work on Rollup. This would enable the possibility of importing an adapter, so we wouldn't have to re-implement an adapter in each test app. We suggest keeping the present PR on hold until Chris has finished that work, then we can rebase and include this improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants