Skip to content

Added lerna-alias dep to automate creating jest aliases#506

Merged
emmatown merged 2 commits into
emotion-js:masterfrom
Andarist:use-lerna-alias
Dec 23, 2017
Merged

Added lerna-alias dep to automate creating jest aliases#506
emmatown merged 2 commits into
emotion-js:masterfrom
Andarist:use-lerna-alias

Conversation

@Andarist
Copy link
Copy Markdown
Member

What:
Added lerna-alias dependency and used it in jest configs

Why:
To automate generating those aliases

Checklist:

  • Documentation N/A
  • Tests
  • Code complete

@mitchellhamilton regarding #464 (comment) - could u point me to the rollup.config.js in which you have wanted to use it? would love to see what's happening to fix the issue

Copy link
Copy Markdown
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! The rollup config is in the repo root(only the UMD bit, where alias is already used), I'm guessing the problem was that the cwd was in the individual packages so passing __dirname to lerna-alias would probably fix it.

@emmatown emmatown merged commit 7746fa6 into emotion-js:master Dec 23, 2017
@Andarist Andarist deleted the use-lerna-alias branch December 24, 2017 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants