Change hash implementation#544
Merged
Merged
Conversation
Codecov Report
|
Member
|
Perf results on iOS are fairly poor. Any worry about this being a bottleneck? |
tkh44
approved these changes
Jan 22, 2018
Member
Author
|
@greggb I didn't test these on iOS but I'm guessing you're referring to Safari? While the hashmumur2 functions are slower than |
Member
|
@mitchellhamilton That's what I had figured (user code as bottleneck), but I thought it was worth mentioning as older phones may suffer more. Unitless graph on an X for posterity (couldn't scroll to get numbers) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What:
Use a different implementation of murmurhash2 https://github.com/garycourt/murmurhash-js/blob/master/murmurhash2_gc.js (react-native-web also uses this)
Why:
Closes #536
It's generally faster and smaller than that the one we use currently but it's the same algorithm so none of the hashes will change.
Chrome results

Firefox results

Safari Results

How:
Checklist: