Skip to content

Fix SSR with multiple createEmotion calls with the same context#605

Merged
emmatown merged 1 commit into
masterfrom
fix-ssr-with-multiple-create-emotion-calls-with-the-same-context
Mar 23, 2018
Merged

Fix SSR with multiple createEmotion calls with the same context#605
emmatown merged 1 commit into
masterfrom
fix-ssr-with-multiple-create-emotion-calls-with-the-same-context

Conversation

@emmatown
Copy link
Copy Markdown
Member

@emmatown emmatown commented Mar 21, 2018

What:
Fix SSR with multiple createEmotion calls with the same context

Why:
Closes #603

How:
Store the emotion instance instead of the caches on the context object.

Checklist:

  • Documentation N/A
  • Tests
  • Code complete

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 21, 2018

Codecov Report

Merging #605 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
packages/create-emotion/src/index.js 100% <100%> (ø) ⬆️

@emmatown emmatown requested a review from tkh44 March 21, 2018 08:03
@emmatown emmatown merged commit 65fac47 into master Mar 23, 2018
@emmatown emmatown deleted the fix-ssr-with-multiple-create-emotion-calls-with-the-same-context branch March 23, 2018 02:33
@whmountains
Copy link
Copy Markdown

This is awesome 🎉 When can we expect a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSR doesn't work with multiple emotion instances.

2 participants