Fix react-emotion typing#678
Merged
Merged
Conversation
1 task
emmatown
reviewed
May 26, 2018
Member
emmatown
left a comment
emmatown
left a comment
There was a problem hiding this comment.
Would it be possible to export CreateStyled as ThemedReactEmotionInterface as well so that it doesn't break people who are using that?(just to be clear I don't mean renaming it, I mean exporting CreateStyled and ThemedReactEmotionInterface where the latter is an alias for CreateStyled)
Member
Author
|
Hm, OK. Are there any more alias I should add? |
Ailrun
force-pushed
the
typing/react-emotion
branch
from
425a63e to
db28a9f
Compare
Member
Author
|
@mitchellhamilton Could I ask one question? If this is merged, when it will be published? |
This was referenced May 30, 2018
Ailrun
force-pushed
the
typing/react-emotion
branch
from
3c896df to
4365715
Compare
Member
Author
|
@mitchellhamilton Please let me know the problems of (or your opinion about) this PR. |
|
Just tested this PR on my project. Looks good to me and fixes #672 nicely. Thank you! Eagerly waiting for the release :) |
emmatown
approved these changes
Jun 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Fixing react-emotion typing
Why: Current typing is redundant.
How: Using
create-emotion-styledtypingChecklist:
I will send a PR for fixing typescript document after this PR is merged.