Fix data-diff first line bug#57
Merged
mansona merged 4 commits intoempress:mainfrom Aug 22, 2023
fry69:diff-info-fix
Merged
Conversation
✅ Deploy Preview for ember-showdown-prism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
No clue how to fix this, I did not touch anything knowingly that could provoke an |
mansona
approved these changes
Aug 22, 2023
Member
mansona
left a comment
There was a problem hiding this comment.
This is an amazing change 🎉 thanks for the change. I would love you to remove the (?bug) comment but it's not a requirement for merging 👍
Member
|
@fry69 regarding the Embroider error, you can ignore it. It's because of a new embroider feature that was recently added in embroider-build/embroider#1521 I will fix that at a later date, and it's nothing that you have done to cause that issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #56
I am happy with this so far, awaiting comments.