Python3 port #14
Open
Python3 port #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to be working just fine. Will test it again tomorrow before PR'ing
…code changed to py3 syntax.
…network that still needs to be fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Python2 end-of-life around the corner, I made a quick py3 port for this project.
Most of it was untouched, the main fixes resolving around python3 string encoding and a few SimpleHTTPServer tweaks.
The code was tested in two Win10 VMs, one of them in an AD. The tests went by smooth and the only errors they raised were "at" being deprecated, the domain comands failing in the non-AD VM and one permission error that I'm quite sure is due a misconfiguration of the VM.