Skip to content

Conversation

@hustxiayang
Copy link
Contributor

@hustxiayang hustxiayang commented Dec 5, 2025

Description
Gemini embedding api in vertex ai : https://docs.cloud.google.com/vertex-ai/generative-ai/docs/model-reference/text-embeddings-api#generative-ai-get-text-embedding-drest

Somethings may need discussions:

  • I extend the input so that it can set task type for each string/text.
  • I also allow users to set a global task type for the embedding requests, which follows vendor-specific fields. This should be convenient for users, and similar to gemini api: https://ai.google.dev/gemini-api/docs/embeddings#task-types

@hustxiayang hustxiayang requested a review from a team as a code owner December 5, 2025 20:33
@hustxiayang hustxiayang marked this pull request as draft December 5, 2025 20:33
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 5, 2025
Signed-off-by: yxia216 <[email protected]>
Signed-off-by: yxia216 <[email protected]>
Signed-off-by: yxia216 <[email protected]>
Signed-off-by: yxia216 <[email protected]>
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 77.73109% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.29%. Comparing base (502d8ad) to head (a6c4a20).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/apischema/openai/union.go 68.11% 12 Missing and 10 partials ⚠️
...ternal/translator/openai_gcpvertexai_embeddings.go 86.77% 10 Missing and 6 partials ⚠️
internal/translator/openai_gcpvertexai.go 60.71% 10 Missing and 1 partial ⚠️
internal/endpointspec/endpointspec.go 0.00% 2 Missing ⚠️
...rnal/tracing/openinference/openai/request_attrs.go 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1625      +/-   ##
==========================================
- Coverage   83.41%   83.29%   -0.12%     
==========================================
  Files         138      139       +1     
  Lines       12447    12664     +217     
==========================================
+ Hits        10383    10549     +166     
- Misses       1431     1465      +34     
- Partials      633      650      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hustxiayang
Copy link
Contributor Author

/retest

2 similar comments
@hustxiayang
Copy link
Contributor Author

/retest

@hustxiayang
Copy link
Contributor Author

/retest

@hustxiayang hustxiayang marked this pull request as ready for review December 12, 2025 18:30
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants