Skip to content

Conversation

@zhaohuabing
Copy link
Member

No description provided.

* release note for v1.2.3

Signed-off-by: Huabing Zhao <[email protected]>

---------

Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing zhaohuabing requested a review from a team as a code owner November 30, 2024 04:55
@codecov
Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.61%. Comparing base (56b0cea) to head (8c7fbb4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4820   +/-   ##
=======================================
  Coverage   65.61%   65.61%           
=======================================
  Files         211      211           
  Lines       31999    31999           
=======================================
  Hits        20995    20995           
  Misses       9761     9761           
  Partials     1243     1243           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

{{- end -}}
{{- with (strings.HasPrefix $pagePrefix "v1.2") -}}
{{- "v1.2.2" -}}
{{- "v1.2.3" -}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be part of another PR, else this will cause the.docs.site to be broken for some duration

Copy link
Member Author

@zhaohuabing zhaohuabing Dec 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a better approach would be publishing the release first, then modify the doc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah +1

Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing zhaohuabing merged commit 81faf42 into envoyproxy:main Dec 2, 2024
21 checks passed
@zhaohuabing zhaohuabing deleted the release-note-v1.2.3 branch December 2, 2024 01:37
zhaohuabing added a commit to zhaohuabing/gateway that referenced this pull request Dec 2, 2024
* [release/v1.2] release note for v1.2.3 (envoyproxy#4813)

* release note for v1.2.3

Signed-off-by: Huabing Zhao <[email protected]>

---------

Signed-off-by: Huabing Zhao <[email protected]>

* address comment

Signed-off-by: Huabing Zhao <[email protected]>

---------

Signed-off-by: Huabing Zhao <[email protected]>
Co-authored-by: Arko Dasgupta <[email protected]>
(cherry picked from commit 81faf42)
Signed-off-by: Huabing Zhao <[email protected]>
zhaohuabing added a commit that referenced this pull request Dec 2, 2024
* [release/v1.2] release note for v1.2.3 (#4820)

* [release/v1.2] release note for v1.2.3 (#4813)

* release note for v1.2.3

Signed-off-by: Huabing Zhao <[email protected]>

---------

Signed-off-by: Huabing Zhao <[email protected]>

* address comment

Signed-off-by: Huabing Zhao <[email protected]>

---------

Signed-off-by: Huabing Zhao <[email protected]>
Co-authored-by: Arko Dasgupta <[email protected]>
(cherry picked from commit 81faf42)
Signed-off-by: Huabing Zhao <[email protected]>

* fix gen check

Signed-off-by: Huabing Zhao <[email protected]>

---------

Signed-off-by: Huabing Zhao <[email protected]>
Co-authored-by: Arko Dasgupta <[email protected]>
zhaohuabing added a commit to zhaohuabing/gateway that referenced this pull request Dec 9, 2024
…nvoyproxy#4824)

* [release/v1.2] release note for v1.2.3 (envoyproxy#4820)

* [release/v1.2] release note for v1.2.3 (envoyproxy#4813)

* release note for v1.2.3

Signed-off-by: Huabing Zhao <[email protected]>

---------

Signed-off-by: Huabing Zhao <[email protected]>

* address comment

Signed-off-by: Huabing Zhao <[email protected]>

---------

Signed-off-by: Huabing Zhao <[email protected]>
Co-authored-by: Arko Dasgupta <[email protected]>
(cherry picked from commit 81faf42)
Signed-off-by: Huabing Zhao <[email protected]>

* fix gen check

Signed-off-by: Huabing Zhao <[email protected]>

---------

Signed-off-by: Huabing Zhao <[email protected]>
Co-authored-by: Arko Dasgupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants