-
Notifications
You must be signed in to change notification settings - Fork 616
feat: Implement ZoneAware loadbalancing - Use non-static local_cluster name (splitup #6482) #6497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement ZoneAware loadbalancing - Use non-static local_cluster name (splitup #6482) #6497
Conversation
Signed-off-by: Jukie <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6497 +/- ##
=======================================
Coverage 71.00% 71.00%
=======================================
Files 225 225
Lines 38950 38958 +8
=======================================
+ Hits 27657 27664 +7
+ Misses 9691 9690 -1
- Partials 1602 1604 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/retest |
|
/retest |
|
/retest |
9f24504 to
4008678
Compare
Signed-off-by: jukie <[email protected]>
|
/retest |
Signed-off-by: jukie <[email protected]>
Signed-off-by: jukie <[email protected]>
|
/retest |
arkodg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
|
/retest |
|
/retest |
What type of PR is this?
feat: Implement ZoneAware Lb Config
What this PR does / why we need it:
Relates to the implementation for
LoadBalancer.ZoneAwareAPI (Ref: #6154)Adjusts the bootstrap local_cluster name to be modeled after the proxy infra name. This will later be used to track EnvoyProxy endpoints and render them via xDS.
Functionality-wise this is a no-op an changes the bootstrap cluster name from
local_clusterto a non-static value generated based on the computed infra name.Which issue(s) this PR fixes:
xRef #6025
Release Notes: No
(will add release note for whichever PR gets merged last)