Skip to content

Conversation

@jukie
Copy link
Contributor

@jukie jukie commented Jul 10, 2025

What type of PR is this?
feat: Implement ZoneAware Lb Config

What this PR does / why we need it:
Relates to the implementation for LoadBalancer.ZoneAware API (Ref: #6154)

Adjusts the bootstrap local_cluster name to be modeled after the proxy infra name. This will later be used to track EnvoyProxy endpoints and render them via xDS.

Functionality-wise this is a no-op an changes the bootstrap cluster name from local_cluster to a non-static value generated based on the computed infra name.

Which issue(s) this PR fixes:

xRef #6025

Release Notes: No
(will add release note for whichever PR gets merged last)

@jukie jukie changed the title Use non-staic local_cluster name feat: Implement ZoneAware loadbalancing - Use non-staic local_cluster name (splitup #6482) Jul 10, 2025
@jukie jukie marked this pull request as ready for review July 10, 2025 00:33
@jukie jukie requested a review from a team as a code owner July 10, 2025 00:33
@codecov
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.00%. Comparing base (2504990) to head (f99c795).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6497   +/-   ##
=======================================
  Coverage   71.00%   71.00%           
=======================================
  Files         225      225           
  Lines       38950    38958    +8     
=======================================
+ Hits        27657    27664    +7     
+ Misses       9691     9690    -1     
- Partials     1602     1604    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jukie
Copy link
Contributor Author

jukie commented Jul 10, 2025

/retest

@jukie
Copy link
Contributor Author

jukie commented Jul 12, 2025

/retest

@arkodg arkodg added this to the v1.5.0-rc.1 Release milestone Jul 16, 2025
@jukie
Copy link
Contributor Author

jukie commented Jul 16, 2025

/retest

@jukie jukie force-pushed the split-impl-zone-aware-routing-local-cluster branch from 9f24504 to 4008678 Compare July 24, 2025 15:34
Signed-off-by: jukie <[email protected]>
@jukie jukie requested a review from arkodg July 24, 2025 15:36
@jukie
Copy link
Contributor Author

jukie commented Jul 24, 2025

/retest

@jukie jukie changed the title feat: Implement ZoneAware loadbalancing - Use non-staic local_cluster name (splitup #6482) feat: Implement ZoneAware loadbalancing - Use non-static local_cluster name (splitup #6482) Jul 24, 2025
@jukie jukie requested a review from arkodg July 24, 2025 17:58
@jukie
Copy link
Contributor Author

jukie commented Jul 24, 2025

/retest

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team July 24, 2025 18:19
@jukie
Copy link
Contributor Author

jukie commented Jul 24, 2025

/retest

@jukie
Copy link
Contributor Author

jukie commented Jul 25, 2025

/retest

@arkodg arkodg merged commit 6be1747 into envoyproxy:main Jul 25, 2025
41 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants