Skip to content

Conversation

@zhaohuabing
Copy link
Member

@zhaohuabing zhaohuabing commented Jul 16, 2025

This PR extends BackendTLSSettings support to all Backend types. If TLS is specified in the BackendTLSSettings field of a Backend resource, and a BackendTLSPolicy is also configured for the backend, the final TLS settings will
be a merge of both configurations. In case of overlapping fields, the values defined in the BackendTLSPolicy will
take precedence.
impl: #6257
Release note: yes

@zhaohuabing zhaohuabing requested a review from a team as a code owner July 16, 2025 06:33
@zhaohuabing zhaohuabing marked this pull request as draft July 16, 2025 06:33
@zhaohuabing zhaohuabing marked this pull request as ready for review July 17, 2025 03:23
@codecov
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

❌ Patch coverage is 91.58879% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.02%. Comparing base (709b250) to head (a2ac71b).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/backendtlspolicy.go 85.41% 4 Missing and 3 partials ⚠️
internal/gatewayapi/backend.go 96.49% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6533      +/-   ##
==========================================
+ Coverage   70.96%   71.02%   +0.06%     
==========================================
  Files         225      225              
  Lines       38919    39075     +156     
==========================================
+ Hits        27617    27754     +137     
- Misses       9699     9714      +15     
- Partials     1603     1607       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zhaohuabing zhaohuabing added this to the v1.5.0-rc.1 Release milestone Jul 17, 2025
@zhaohuabing zhaohuabing changed the title apply backendTLSSettings to all Backend Types feat: apply backendTLSSettings to all Backend Types Jul 17, 2025
@zhaohuabing zhaohuabing force-pushed the impl-6257 branch 2 times, most recently from 30ae0e0 to c353194 Compare July 17, 2025 03:48
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
@zhaohuabing zhaohuabing requested a review from arkodg July 24, 2025 10:29
arkodg
arkodg previously approved these changes Jul 25, 2025
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@arkodg arkodg requested review from a team July 25, 2025 21:57
Signed-off-by: Huabing Zhao <[email protected]>
@arkodg arkodg requested a review from a team July 27, 2025 14:44
@arkodg arkodg requested a review from a team July 27, 2025 14:44
@zhaohuabing zhaohuabing merged commit 182b761 into envoyproxy:main Jul 28, 2025
47 of 50 checks passed
@zhaohuabing zhaohuabing deleted the impl-6257 branch July 28, 2025 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants