Skip to content

Conversation

@fengxsong
Copy link
Contributor

What type of PR is this?

bugfix

What this PR does / why we need it:

corev1.Node objects in Kubernetes are cluster-level resources that don't have a namespace, then r.hasMatchingNamespaceLabels function will always return false, nil.

@fengxsong fengxsong requested a review from a team as a code owner July 21, 2025 08:04
@codecov
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.15%. Comparing base (b58edd7) to head (3d1db4b).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6565      +/-   ##
==========================================
+ Coverage   71.12%   71.15%   +0.03%     
==========================================
  Files         220      220              
  Lines       37971    37967       -4     
==========================================
+ Hits        27005    27015      +10     
+ Misses       9393     9381      -12     
+ Partials     1573     1571       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@arkodg arkodg requested review from a team July 21, 2025 21:57
@arkodg arkodg added this to the v1.5.0-rc.1 Release milestone Jul 21, 2025
@zhaohuabing zhaohuabing enabled auto-merge (squash) July 22, 2025 01:40
@zhaohuabing zhaohuabing merged commit 401d9b7 into envoyproxy:main Jul 22, 2025
45 of 47 checks passed
@fengxsong fengxsong deleted the patch-1 branch July 22, 2025 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants