-
Notifications
You must be signed in to change notification settings - Fork 616
api: add ClientCertificateRef field to ExtensionTLS for mTLS support #6674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: add ClientCertificateRef field to ExtensionTLS for mTLS support #6674
Conversation
ab6054f to
8b6ae2f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6674 +/- ##
==========================================
+ Coverage 71.04% 71.09% +0.04%
==========================================
Files 225 225
Lines 39795 39798 +3
==========================================
+ Hits 28274 28296 +22
+ Misses 9854 9840 -14
+ Partials 1667 1662 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@wenfengp run |
Signed-off-by: Wenfeng <[email protected]>
8b6ae2f to
f2a9cca
Compare
Signed-off-by: Wenfeng <[email protected]>
f2a9cca to
03986d5
Compare
Signed-off-by: Wenfeng <[email protected]>
88bd54b to
ac6902e
Compare
Signed-off-by: Wenfeng <[email protected]>
5600409 to
9d9192c
Compare
|
Implementation PR: #6777 |
Signed-off-by: Wenfeng <[email protected]>
arkodg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
guydc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Wenfeng <[email protected]>
|
e2e test failed, seems flaky, updated branch. |
What type of PR is this?
api: add ClientCertificateRef field to ExtensionTLS for mTLS support
Implementation will in a separate PR #6777 after this API PR get approved
What this PR does / why we need it:
This PR adds mutual TLS (mTLS) support for Extension Servers by introducing a new optional
ClientCertificateReffield to theExtensionTLSstruct.Changes:
ClientCertificateReffield toExtensionTLSstruct inapi/v1alpha1/envoygateway_types.gomake kube-generateBackground:
Currently, Envoy Gateway only supports server certificate validation when connecting to extension servers. Many enterprise environments require mutual TLS authentication where the extension server also validates the client (Envoy Gateway) certificate for enhanced security.
API Design:
ClientCertificateRefis optional, maintaining full backwards compatibilitytls.crtandtls.keyExample Usage:
This API change enables enterprise security requirements while maintaining zero breaking changes for existing users.
Which issue(s) this PR fixes:
Fixes # #5155
Release Notes: Yes