Skip to content

Conversation

@zirain
Copy link
Member

@zirain zirain commented Aug 5, 2025

fixes: #6677

@zirain zirain requested a review from a team as a code owner August 5, 2025 08:01
@zirain
Copy link
Member Author

zirain commented Aug 5, 2025

cc @jukie

@codecov
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.02%. Comparing base (2488496) to head (8ddef22).
⚠️ Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
internal/utils/labels/match.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6702      +/-   ##
==========================================
+ Coverage   71.00%   71.02%   +0.02%     
==========================================
  Files         224      225       +1     
  Lines       39621    39620       -1     
==========================================
+ Hits        28132    28142      +10     
+ Misses       9828     9819       -9     
+ Partials     1661     1659       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zirain
Copy link
Member Author

zirain commented Aug 5, 2025

looks like this refactor break zone aware routing

@zirain zirain force-pushed the fix/selector-match branch 3 times, most recently from 3dfec20 to e1f4bb7 Compare August 9, 2025 15:33
zirain added 2 commits August 11, 2025 17:36
Signed-off-by: zirain <[email protected]>
@zirain zirain force-pushed the fix/selector-match branch from e1f4bb7 to 8ddef22 Compare August 11, 2025 09:36
@arkodg arkodg merged commit 5eedb5c into envoyproxy:main Aug 11, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor labels match

4 participants