Skip to content

chore: Don't render bootstrap local cluster if topologyInjector is disabled #6718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arkodg merged 8 commits into from
Aug 7, 2025
Merged

chore: Don't render bootstrap local cluster if topologyInjector is disabled #6718

arkodg merged 8 commits into from
Aug 7, 2025

Conversation

@jukie
Copy link
Contributor

@jukie jukie commented Aug 6, 2025 •
edited
Loading

Fixes #6689

@jukie
Copy link
Contributor Author

jukie commented Aug 6, 2025

CC @arkodg

@codecov
Copy link

codecov bot commented Aug 6, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.99%. Comparing base (14a02b0) to head (ab60fa4).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/infrastructure/host/proxy_infra.go 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6718      +/-   ##
==========================================
- Coverage   71.00%   70.99%   -0.01%     
==========================================
  Files         224      224              
  Lines       39606    39627      +21     
==========================================
+ Hits        28122    28133      +11     
- Misses       9824     9832       +8     
- Partials     1660     1662       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arkodg arkodg added this to the v1.5.0 Release milestone Aug 6, 2025
@jukie jukie changed the title Consider topologyInjector when rendering bootstrap chore: Don't render bootstrap local cluster if topologyInjector is disabled Aug 6, 2025
@jukie
Copy link
Contributor Author

jukie commented Aug 6, 2025

/retest

@jukie
Handle nil gateway
b880b2a 
Signed-off-by: jukie <[email protected]>
@jukie jukie marked this pull request as ready for review August 6, 2025 22:19
@jukie jukie requested a review from a team as a code owner August 6, 2025 22:19
@jukie jukie requested review from a team and arkodg August 6, 2025 22:19
arkodg
arkodg reviewed Aug 6, 2025
View reviewed changes
@jukie
add to helpers
a18f446 
Signed-off-by: jukie <[email protected]>
@jukie jukie requested a review from arkodg August 6, 2025 22:37
arkodg
arkodg reviewed Aug 6, 2025
View reviewed changes
@jukie jukie requested a review from arkodg August 7, 2025 01:16
arkodg
arkodg previously approved these changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@arkodg arkodg requested review from a team August 7, 2025 01:25
@jukie
Copy link
Contributor Author

jukie commented Aug 7, 2025

/retest

@jukie
nil handlers
ab60fa4 
Signed-off-by: jukie <[email protected]>
@jukie jukie requested a review from arkodg August 7, 2025 01:42
@jukie
Copy link
Contributor Author

jukie commented Aug 7, 2025

/retest

@zirain
Copy link
Member

zirain commented Aug 7, 2025

can we add a test case for this?

@arkodg arkodg requested review from a team August 7, 2025 14:38
@arkodg arkodg merged commit 1c2bbb9 into envoyproxy:main Aug 7, 2025
46 of 51 checks passed
zirain pushed a commit to zirain/gateway that referenced this pull request Aug 8, 2025
@jukie @zirain
chore: Don't render bootstrap local cluster if topologyInjector is di…
d15d8a2 
…sabled (envoyproxy#6718)

* Consider topologyInjector when rendering bootstrap

Signed-off-by: jukie <[email protected]>

* Add logic to provider

Signed-off-by: jukie <[email protected]>
zirain pushed a commit to zirain/gateway that referenced this pull request Aug 8, 2025
@jukie @zirain
chore: Don't render bootstrap local cluster if topologyInjector is di…
d1b2c1d 
…sabled (envoyproxy#6718)

* Consider topologyInjector when rendering bootstrap

Signed-off-by: jukie <[email protected]>

* Add logic to provider

Signed-off-by: jukie <[email protected]>
Signed-off-by: zirain <[email protected]>
zirain added a commit that referenced this pull request Aug 8, 2025
@zirain @arkodg
@commoddity @rpahli @maxbrunet @jukie
[release-1.5] cherry pick for v1.5.0 (#6738)
c2e5b2e 
* docs: rm latest from install egctl docs (#6700)

* we've removed the latest egctl artifacts

Relates to #6551

Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: zirain <[email protected]>

* chore: fix globalResources in GNM (#6701)

Signed-off-by: zirain <[email protected]>

* move ordering gateway-api resources to provider (#6695)

Signed-off-by: zirain <[email protected]>

* Rate Limiter: Enable rate limit for month and year (#6715)

* update go control plane rate limiter version

Signed-off-by: Pascal van Leeuwen <[email protected]>

* enable rate limit for month and year

Signed-off-by: Pascal van Leeuwen <[email protected]>

* add attribution

Signed-off-by: Pascal van Leeuwen <[email protected]>

* fix gen

Signed-off-by: Pascal van Leeuwen <[email protected]>

* remove helm binaries

Signed-off-by: Pascal van Leeuwen <[email protected]>

---------

Signed-off-by: Pascal van Leeuwen <[email protected]>
Co-authored-by: Rico Pahlisch <[email protected]>
Signed-off-by: zirain <[email protected]>

* docs: rm alpha alert for gateway namespace mode (#6709)

Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: zirain <[email protected]>

* allow SNI and Cert SAN mismatch (#6719)

Fixes: #6442

Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: zirain <[email protected]>

* chore(charts): update metadata for gateway-crds-helm (#6725)

* chore(charts): update metadata for gateway-crds-helm

Signed-off-by: Maxime Brunet <[email protected]>
Signed-off-by: zirain <[email protected]>

* chore: Don't render bootstrap local cluster if topologyInjector is disabled (#6718)

* Consider topologyInjector when rendering bootstrap

Signed-off-by: jukie <[email protected]>

* Add logic to provider

Signed-off-by: jukie <[email protected]>
Signed-off-by: zirain <[email protected]>

* remove nit log when Backend API is disabled (#6708)

* remove nit log when Backend API is disabled

Signed-off-by: zirain <[email protected]>

* fix: EnvoyProxy image with digest is rejected (#6720)

* fix: EnvoyProxy image with digest is rejected

Signed-off-by: zirain <[email protected]>

* Revert "feat: add listener metadata (#6639)" (#6727)

This reverts commit 20cb68b.

Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: zirain <[email protected]>

* docs: enhance extensibility index page (#6728)

make it easier to pick the relevant extension type

Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: zirain <[email protected]>

* docs: add docs explaining graceful shutdown (#6729)

* docs: add docs explaining graceful shutdown

fixes: #2686

Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: zirain <[email protected]>

* docs: ClusterTrustBundle Support in BackendTLSPolicy (#6714)

Signed-off-by: zirain <[email protected]>

* chore: bump go 1.24.6 (#6732)

Signed-off-by: zirain <[email protected]>

* [release-1.5] release-notes for v1.5.0 (#6731)

* [release-1.5] release-notes for v1.5.0

Signed-off-by: zirain <[email protected]>

* update compatibility matrix

Signed-off-by: zirain <[email protected]>

---------

Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: Pascal van Leeuwen <[email protected]>
Signed-off-by: Maxime Brunet <[email protected]>
Signed-off-by: jukie <[email protected]>
Co-authored-by: Arko Dasgupta <[email protected]>
Co-authored-by: commoddity <[email protected]>
Co-authored-by: Rico Pahlisch <[email protected]>
Co-authored-by: Maxime Brunet <[email protected]>
Co-authored-by: Isaac <[email protected]>
zirain added a commit to zirain/gateway that referenced this pull request Sep 16, 2025
@zirain @arkodg
@commoddity @rpahli @maxbrunet @jukie
[release-1.5] cherry pick for v1.5.0 (envoyproxy#6738)
b573ba4 
* docs: rm latest from install egctl docs (envoyproxy#6700)

* we've removed the latest egctl artifacts

Relates to envoyproxy#6551

Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: zirain <[email protected]>

* chore: fix globalResources in GNM (envoyproxy#6701)

Signed-off-by: zirain <[email protected]>

* move ordering gateway-api resources to provider (envoyproxy#6695)

Signed-off-by: zirain <[email protected]>

* Rate Limiter: Enable rate limit for month and year (envoyproxy#6715)

* update go control plane rate limiter version

Signed-off-by: Pascal van Leeuwen <[email protected]>

* enable rate limit for month and year

Signed-off-by: Pascal van Leeuwen <[email protected]>

* add attribution

Signed-off-by: Pascal van Leeuwen <[email protected]>

* fix gen

Signed-off-by: Pascal van Leeuwen <[email protected]>

* remove helm binaries

Signed-off-by: Pascal van Leeuwen <[email protected]>

---------

Signed-off-by: Pascal van Leeuwen <[email protected]>
Co-authored-by: Rico Pahlisch <[email protected]>
Signed-off-by: zirain <[email protected]>

* docs: rm alpha alert for gateway namespace mode (envoyproxy#6709)

Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: zirain <[email protected]>

* allow SNI and Cert SAN mismatch (envoyproxy#6719)

Fixes: envoyproxy#6442

Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: zirain <[email protected]>

* chore(charts): update metadata for gateway-crds-helm (envoyproxy#6725)

* chore(charts): update metadata for gateway-crds-helm

Signed-off-by: Maxime Brunet <[email protected]>
Signed-off-by: zirain <[email protected]>

* chore: Don't render bootstrap local cluster if topologyInjector is disabled (envoyproxy#6718)

* Consider topologyInjector when rendering bootstrap

Signed-off-by: jukie <[email protected]>

* Add logic to provider

Signed-off-by: jukie <[email protected]>
Signed-off-by: zirain <[email protected]>

* remove nit log when Backend API is disabled (envoyproxy#6708)

* remove nit log when Backend API is disabled

Signed-off-by: zirain <[email protected]>

* fix: EnvoyProxy image with digest is rejected (envoyproxy#6720)

* fix: EnvoyProxy image with digest is rejected

Signed-off-by: zirain <[email protected]>

* Revert "feat: add listener metadata (envoyproxy#6639)" (envoyproxy#6727)

This reverts commit 20cb68b.

Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: zirain <[email protected]>

* docs: enhance extensibility index page (envoyproxy#6728)

make it easier to pick the relevant extension type

Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: zirain <[email protected]>

* docs: add docs explaining graceful shutdown (envoyproxy#6729)

* docs: add docs explaining graceful shutdown

fixes: envoyproxy#2686

Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: zirain <[email protected]>

* docs: ClusterTrustBundle Support in BackendTLSPolicy (envoyproxy#6714)

Signed-off-by: zirain <[email protected]>

* chore: bump go 1.24.6 (envoyproxy#6732)

Signed-off-by: zirain <[email protected]>

* [release-1.5] release-notes for v1.5.0 (envoyproxy#6731)

* [release-1.5] release-notes for v1.5.0

Signed-off-by: zirain <[email protected]>

* update compatibility matrix

Signed-off-by: zirain <[email protected]>

---------

Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: Pascal van Leeuwen <[email protected]>
Signed-off-by: Maxime Brunet <[email protected]>
Signed-off-by: jukie <[email protected]>
Co-authored-by: Arko Dasgupta <[email protected]>
Co-authored-by: commoddity <[email protected]>
Co-authored-by: Rico Pahlisch <[email protected]>
Co-authored-by: Maxime Brunet <[email protected]>
Co-authored-by: Isaac <[email protected]>
Signed-off-by: zirain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zirain zirain zirain approved these changes

@arkodg arkodg arkodg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.5.0 Release

Development

Successfully merging this pull request may close these issues.

Dont add Proxy fleet (ServiceCluster) resources if Topology Injector is disabled

3 participants

@jukie @zirain @arkodg