-
Notifications
You must be signed in to change notification settings - Fork 616
benchmark: use custom duration in prom metric #6811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
arkodg
commented
Aug 18, 2025
- determine the time duration more accurately instead of using 30s, which may be reading values across tests
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6811 +/- ##
==========================================
+ Coverage 71.04% 71.05% +0.01%
==========================================
Files 225 225
Lines 39810 39810
==========================================
+ Hits 28282 28288 +6
+ Misses 9859 9857 -2
+ Partials 1669 1665 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4ce80e7 to
fe19e99
Compare
zhaohuabing
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
* determine the time duration more accurately instead of using 30s, which may be reading values across tests Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: Arko Dasgupta <[email protected]>
cf90736 to
c672508
Compare
|
/retest |