Skip to content

Conversation

@arkodg
Copy link
Contributor

@arkodg arkodg commented Aug 18, 2025

  • determine the time duration more accurately instead of using 30s, which may be reading values across tests

@arkodg arkodg requested a review from a team as a code owner August 18, 2025 11:36
@arkodg arkodg requested review from shawnh2 and zirain August 18, 2025 11:36
@codecov
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.05%. Comparing base (c19352e) to head (c672508).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6811      +/-   ##
==========================================
+ Coverage   71.04%   71.05%   +0.01%     
==========================================
  Files         225      225              
  Lines       39810    39810              
==========================================
+ Hits        28282    28288       +6     
+ Misses       9859     9857       -2     
+ Partials     1669     1665       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arkodg arkodg force-pushed the accurate-duration branch from 4ce80e7 to fe19e99 Compare August 20, 2025 07:09
@arkodg arkodg requested a review from zirain August 20, 2025 07:55
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

Arko Dasgupta added 4 commits August 20, 2025 16:57
* determine the time duration more accurately instead
of using 30s, which may be reading values across tests

Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: Arko Dasgupta <[email protected]>
@zirain zirain force-pushed the accurate-duration branch from cf90736 to c672508 Compare August 20, 2025 09:57
@zirain zirain enabled auto-merge (squash) August 20, 2025 09:57
@zirain
Copy link
Member

zirain commented Aug 20, 2025

/retest

@zirain zirain merged commit aee4b91 into envoyproxy:main Aug 20, 2025
51 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants