Add support for firefox android #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add min_version 68.9. This will allow it to be installed on android from the store. Additionally, 68.9 is 4 years old, so this shouldn't block anyone from installing it on older browser versions.
ericwbailey
requested changes
Aug 27, 2024
Owner
ericwbailey
left a comment
ericwbailey
left a comment
There was a problem hiding this comment.
Apologies for the late reply here. It looks like the extension did what it was set to do 😅
Accept these changes and I'll be sure to update the Firefox extension, fellow Firefox user.
| "manifest_version": 2, | ||
|
|
||
| "name": "Millennials to Snake People", | ||
| "name": "Snake People to Snake People", |
Owner
There was a problem hiding this comment.
Suggested change
| "name": "Snake People to Snake People", | |
| "name": "Millennials to Snake People", |
| "name": "Snake People to Snake People", | ||
| "short_name": "Snake People", | ||
| "description": "Replaces the text 'Millennial' with 'Snake People'.", | ||
| "description": "Replaces the text 'Snake Person' with 'Snake People'.", |
Owner
There was a problem hiding this comment.
Suggested change
| "description": "Replaces the text 'Snake Person' with 'Snake People'.", | |
| "description": "Replaces the text 'Millennials' with 'Snake People'.", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add min_version 68.9.
This will allow it to be installed on android from the store. Additionally, 68.9 is 4 years old, so this shouldn't block anyone from installing it on older browser versions.