Skip to content

fix: update incorrect meta properties #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2025

Conversation

lumirlumir
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

What changes did you make? (Give an overview)

Hello,

In this PR, I've updated incorrect meta properties in index.html and manifest.json.

I think the default meta properties remain unchanged.

Related Issues

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Jun 14, 2025
Copy link

netlify bot commented Jun 14, 2025

Deploy Preview for eslint-code-explorer ready!

Name Link
🔨 Latest commit 8f35c80
🔍 Latest deploy log https://app.netlify.com/projects/eslint-code-explorer/deploys/6851377372c77b0008c15902
😎 Deploy Preview https://deploy-preview-112--eslint-code-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lumirlumir lumirlumir requested review from a team June 14, 2025 14:12
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jun 14, 2025
@amareshsm amareshsm moved this from Needs Triage to Triaging in Triage Jun 16, 2025
@lumirlumir
Copy link
Member Author

lumirlumir commented Jun 17, 2025

@amareshsm Thanks for your suggestion.

I've used Primary 800 for light mode:

image

Primary 400 for dark mode:

image

And Primary 600 as a default value in manifest.json:

image

@lumirlumir lumirlumir requested a review from amareshsm June 17, 2025 09:42
@lumirlumir lumirlumir added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jun 17, 2025
Copy link

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snitin315 snitin315 merged commit 0c56f33 into main Jun 21, 2025
8 checks passed
@snitin315 snitin315 deleted the fix-update-incorrect-meta-properties branch June 21, 2025 15:49
@github-project-automation github-project-automation bot moved this from Triaging to Complete in Triage Jun 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug Something isn't working
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

3 participants