2.5.0-beta3's libraries/ESP8266WiFi/src/ESP8266WiFiSTA.cpp doesn't compile

[crankyoldgit]

Basic Infos

• This issue complies with the issue POLICY doc.
• I have read the documentation at readthedocs and the issue is not addressed there.
• I have tested that the issue is present in current master branch (aka latest git).
• I have searched the issue tracker for a similar issue.
• If there is a stack dump, I have decoded it.
• I have filled out all fields below.

Platform

• Hardware: [other] / N/A
• Core Version: 2.5.0-beta3 / 21db8fc
• Development Env: Arduino IDE 1,8.8
• Operating System: Unix / Travis

Settings in IDE

• Module: Wemos D1 mini r2 & Nodemcu
• Flash Mode: N/A
• Flash Size: 4M
• lwip Variant: N/A
• Reset Method: N/A
• Flash Frequency: N/A
• CPU Frequency: 80Mhz
• Upload Using: N/A
• Upload Speed: N/A

Problem Description

2.5.0-beta3's libraries/ESP8266WiFi/src/ESP8266WiFiSTA.cpp doesn't compile, has errors.

See https://travis-ci.org/markszabo/IRremoteESP8266/jobs/484962845#L1515

$ arduino --verify --board esp8266:esp8266:nodemcuv2:xtal=80,eesz=4M3M $PWD/examples/IRGCTCPServer/IRGCTCPServer.ino
/home/travis/.arduino15/packages/esp8266/hardware/esp8266/2.5.0-beta3/libraries/ESP8266WiFi/src/ESP8266WiFiSTA.cpp: In member function 'bool ESP8266WiFiSTAClass::hostname(const char*)':
/home/travis/.arduino15/packages/esp8266/hardware/esp8266/2.5.0-beta3/libraries/ESP8266WiFi/src/ESP8266WiFiSTA.cpp:537:52: error: invalid conversion from 'const char*' to 'char*' [-fpermissive]
         intf->hostname = wifi_station_get_hostname();
                                                    ^
/home/travis/.arduino15/packages/esp8266/hardware/esp8266/2.5.0-beta3/libraries/ESP8266WiFi/src/ESP8266WiFiSTA.cpp:539:33: error: 'netif_dhcp_data' was not declared in this scope
         if (netif_dhcp_data(intf) != nullptr) {
                                 ^
exit status 1

This looks like it was introduced in #5652 (7c5be91)

The code has compiled fine with all previous versions of the ESP8266 core libraries for years. e.g. 2.5.0-beta2 was fine. Beta3 broke it.

Sketch

https://github.com/markszabo/IRremoteESP8266/blob/master/examples/IRGCTCPServer/IRGCTCPServer.ino
https://github.com/markszabo/IRremoteESP8266/blob/master/examples/IRMQTTServer/IRMQTTServer.ino
https://github.com/markszabo/IRremoteESP8266/blob/master/examples/IRServer/IRServer.ino

Debug Messages

N/A

[d-a-v]

• lwip Variant: N/A

Are you using lwIP-v1.4 ?

[crankyoldgit]

No idea tbh. It's using what ever the default would be.
Our travis environment is built using:

• wget http://downloads.arduino.cc/arduino-1.8.8-linux64.tar.xz
• tar xf arduino-1.8.8-linux64.tar.xz
• sudo mv arduino-1.8.8 /usr/local/share/arduino
• sudo ln -s /usr/local/share/arduino/arduino /usr/local/bin/arduino
• wget https://raw.githubusercontent.com/google/styleguide/gh-pages/cpplint/cpplint.py
• ln -s $PWD /usr/local/share/arduino/libraries/
• git clone https://github.com/tzapu/WiFiManager.git /usr/local/share/arduino/libraries/WiFiManager
• git clone https://github.com/knolleary/pubsubclient.git /usr/local/share/arduino/libraries/PubSubClient
• arduino --pref "boardsmanager.additional.urls=http://arduino.esp8266.com/stable/package_esp8266com_index.json" --save-prefs
• arduino --install-boards esp8266:esp8266
• arduino --board D=esp8266:esp8266:nodemcuv2:xtal=80,eesz=4M3M --save-prefs
• arduino --pref "compiler.warning_level=all" --save-prefs

(https://github.com/markszabo/IRremoteESP8266/blob/master/.travis.yml)

[d-a-v]

This bug will be fixed asap.

arduino --board D=esp8266:esp8266:nodemcuv2:xtal=80,eesz=4M3M --save-prefs

You may update your board FQBN with ip=lm2f:exception=disabled:

arduino --board D=esp8266:esp8266:nodemcuv2:xtal=80,eesz=4M3M:ip=lm2f:exception=disabled --save-prefs

[crankyoldgit]

Thanks. I'll try it out now.

[crankyoldgit]

You may update your board FQBN with ip=lm2f:exception=disabled:

arduino --board D=esp8266:esp8266:nodemcuv2:xtal=80,eesz=4M3M:ip=lm2f:exception=disabled --save-prefs

I think you meant: ip=lm2f,exception=disabled,

arduino --board D=esp8266:esp8266:nodemcuv2:xtal=80,eesz=4M3M,ip=lm2f,exception=disabled --save-prefs

Which seems to be working/compiling so far.

What does that addition actually do?

[d-a-v]

What does that addition actually do?

I am curious to know wether #5657 would answer to your question.

[crankyoldgit]

Not really. e.g. It doesn't explain what disabling exceptions does and has nothing about the ip= clause.