-
-
Notifications
You must be signed in to change notification settings - Fork 77
Show and archive generated proto-files if diff #1198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1198 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 2900 2900
=========================================
Hits 2900 2900 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #1198 will not alter performanceComparing Summary
|
WalkthroughThe workflow configuration in Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub Actions
participant Runner
participant Codecov
GitHub Actions->>Runner: Start CI workflow
Runner->>Runner: Setup, lint, type check, benchmark
alt Protobuf check passes
Runner->>Runner: Continue workflow (no special action)
else Protobuf check fails (specific matrix)
Runner->>Runner: Show git diff
Runner->>Runner: Upload protobuf artifacts
Runner->>Runner: Run pytest with coverage
Runner->>Codecov: Upload coverage report
end
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)
130-135
: Fix typo in artifact name
The artifact is named"genrated-proto-files"
, which contains a typo. Rename it to"generated-proto-files"
to avoid confusion when downloading artifacts.
Apply this diff:@@ lines 133-134 - name: genrated-proto-files + name: generated-proto-files
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/ci.yml
(1 hunks)
🔇 Additional comments (1)
.github/workflows/ci.yml (1)
127-129
: Show changes on diff detection
This step correctly invokesgit diff
when the protobuf check fails under the specified matrix combination, and theif: ${{ failure() && … }}
guard ensures it only runs in that failure scenario.
Thanks @dala318 |
What does this implement/fix?
If there is a diff in generated Proto-files, show the diff and archive the generated files for download to work-area.
Mitigating having to set-up a type-like proto environment locally.
Example for failed run https://github.com/esphome/aioesphomeapi/actions/runs/15255852122/job/42903200847
Types of changes
Related issue or feature (if applicable):
Pull request in esphome (if applicable):
Checklist:
tests/
folder).