-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Closed
Labels
Resolution: Awaiting responseWaiting for response of authorWaiting for response of author
Milestone
Metadata
Metadata
Assignees
Labels
Resolution: Awaiting responseWaiting for response of authorWaiting for response of author
Type
Projects
Status
Done
Relationships
Development
Select code repository
Activity
GKFernandes commentedon May 19, 2022
Hello @me-no-dev , I think this could be a solution, but can the function verifyOta() just be removed?
What do you think @atanisoft @marcovannoord?
marcovannoord commentedon May 19, 2022
Yeah that would be a perfect solution i think, and it would just skip the verifyOTA() function.
In that case, if users want to use the verifyOTA to immediately verify rollback, then they can still use that function if they override the weak function.
me-no-dev commentedon May 19, 2022
if you overwrite
verifyRollbackLater
, thenverifyOTA
will not be called at all. This whole block will not execute: https://github.com/espressif/arduino-esp32/blob/master/cores/esp32/esp32-hal-misc.c#L215-L226marcovannoord commentedon May 19, 2022
Yeah i think that's the perfect solution. That way, users can add this feature, while keeping legacy things intact.
Add option to skip image verification after OTA
Add option to skip image verification after OTA (#6779)
me-no-dev commentedon May 19, 2022
Done :)
Add option to skip image verification after OTA (espressif#6779) (#140)
zekageri commentedon Nov 1, 2022
Any example for this?