You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I ran into the same issue as stated in: #3318 and also in #3749
I think this issue about the weakly defined verify0ta() should be fixed and made in such a way that the user can perform the verification later in the code instead of inside the initArduino() function.
Yeah that would be a perfect solution i think, and it would just skip the verifyOTA() function.
In that case, if users want to use the verifyOTA to immediately verify rollback, then they can still use that function if they override the weak function.
Activity
me-no-dev commentedon May 13, 2022
How about we add a new weak function
bool verifyRollbackLater()to allow you to skip verification ininitArduinoand do it yourself later?1 remaining item
GKFernandes commentedon May 19, 2022
Hello @me-no-dev , I think this could be a solution, but can the function verifyOta() just be removed?
What do you think @atanisoft @marcovannoord?
marcovannoord commentedon May 19, 2022
Yeah that would be a perfect solution i think, and it would just skip the verifyOTA() function.
In that case, if users want to use the verifyOTA to immediately verify rollback, then they can still use that function if they override the weak function.
me-no-dev commentedon May 19, 2022
if you overwrite
verifyRollbackLater, thenverifyOTAwill not be called at all. This whole block will not execute: https://github.com/espressif/arduino-esp32/blob/master/cores/esp32/esp32-hal-misc.c#L215-L226marcovannoord commentedon May 19, 2022
Yeah i think that's the perfect solution. That way, users can add this feature, while keeping legacy things intact.
Add option to skip image verification after OTA
Add option to skip image verification after OTA (#6779)
me-no-dev commentedon May 19, 2022
Done :)
Add option to skip image verification after OTA (espressif#6779) (#140)
zekageri commentedon Nov 1, 2022
Any example for this?