-
Notifications
You must be signed in to change notification settings - Fork 85
Custom Alpha Image - Resurface Banner on Reject - v2 #7120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-2.76.1
Are you sure you want to change the base?
Custom Alpha Image - Resurface Banner on Reject - v2 #7120
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Greptile OverviewGreptile SummaryThis PR modifies the
Confidence Score: 4/5
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
clients/fides-js/__tests__/lib/consent-utils.test.ts, line 340 (link)style: Test label says "returns false" but the expected value is now
true. Update the label to match the new behavior.
2 files reviewed, 2 comments
| }, | ||
| savedConsent: mockSavedConsent, | ||
| options: {}, | ||
| expected: false, | ||
| expected: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider adding a test case for ConsentMethod.REJECT in TCF experiences to ensure both DISMISS and REJECT behaviors are covered by tests.
Ticket [ENG-2224]
Description Of Changes
Custom alpha image for client. Includes updates in 2.76.1 plus Banner Resurfacing.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works