Skip to content

Upgrade Projects to .NET 6 #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 18, 2021
Merged

Upgrade Projects to .NET 6 #85

merged 5 commits into from
Nov 18, 2021

Conversation

FaisalAfroz
Copy link
Contributor

No description provided.

@FaisalAfroz FaisalAfroz requested a review from a team as a code owner November 10, 2021 07:39
ErikSchierboom
ErikSchierboom reviewed Nov 10, 2021
View reviewed changes
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! The only thing I'd like to see added is a new test solution that still uses net5.0, to verify that the test runner will still work on old solutions.

@FaisalAfroz
Copy link
Contributor Author

Ok I will do a PR with half .net5 and half .net6 .

@FaisalAfroz
Copy link
Contributor Author

FaisalAfroz commented Nov 10, 2021 •
edited
Loading

See #88 . It has both old and new projects.

@ErikSchierboom
Copy link
Member

@FaisalAfroz I'd rather update all projects to .net6 and add a new test solution for .net5.

@ErikSchierboom
Copy link
Member

Even though the CI seems to be passing, it looks like it actually is not: https://github.com/exercism/csharp-test-runner/runs/4163010359?check_suite_focus=true

@ErikSchierboom ErikSchierboom mentioned this pull request Nov 10, 2021
Merged
@ErikSchierboom
Copy link
Member

@FaisalAfroz The tests still fail: https://github.com/exercism/csharp-test-runner/pull/85/checks Something has changed with powershell in one of the updates. A failure in the tests should result in a failing CI. Something to fix in a separate PR.

@FaisalAfroz
Copy link
Contributor Author

Yes, I think that is another issue. If a build fails it should indicate red instead of green.

@ErikSchierboom
Copy link
Member

Let me know when you've managed to fix the build

@ErikSchierboom ErikSchierboom merged commit 3830d27 into exercism:main Nov 18, 2021
@ErikSchierboom
Copy link
Member

Merged! Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FaisalAfroz @ErikSchierboom