Skip to content

two-bucket: fix implemenation #901

Closed
@SleeplessByte

Description

@SleeplessByte
Member

Don't work on this issue until #895 is merged, or use that PR as a base branch.

When two-bucket was synced, it became evident that some of the tests cases are not passing, at all. Fix the implementation so these test cases pass and replace test.skip with xtest: https://github.com/exercism/javascript/blob/774fb12c4d1f492af9658ece4eec515bf92552e7/exercises/two-bucket/two-bucket.spec.js

Activity

slaymance

slaymance commented on Dec 28, 2020

@slaymance
Contributor

Hey @SleeplessByte I noticed the tests throwing for this exercise and submitted a fix in PR 905. We'll still need another PR to update the example solution since it's failing a couple of the new tests, and running into an infinite loop on a couple of them. With this PR, though, we can at least get the tests working for students.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @SleeplessByte@slaymance

      Issue actions

        two-bucket: fix implemenation · Issue #901 · exercism/javascript