Skip to content

Conversation

@glennj
Copy link
Contributor

@glennj glennj commented Jan 14, 2026

In the case where there is only one test, the Odin test runner outputs "Finished 1 test ...". The runner script was always expecting the plural "tests".

Fixes #13

In the case where there is only one test, the Odin test runner outputs "Finished 1 test ...".
The runner script was always expecting the plural "tests".

Fixes exercism#13
@glennj glennj requested a review from a team as a code owner January 14, 2026 15:31
@glennj glennj requested review from rmonnet and removed request for a team January 14, 2026 15:31
@glennj glennj marked this pull request as draft January 14, 2026 15:37
@glennj
Copy link
Contributor Author

glennj commented Jan 14, 2026

putting into draft while I review the failing check

@glennj
Copy link
Contributor Author

glennj commented Jan 14, 2026

error code 132 appears to mean segfault. Why is it segfaulting in GitHub but not locally?

Copy link
Contributor

@rmonnet rmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@glennj glennj marked this pull request as ready for review January 14, 2026 19:08
@glennj glennj merged commit 620a1d6 into exercism:main Jan 14, 2026
1 check passed
@glennj glennj deleted the run.sh-fix branch January 14, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unsatisfying feedback for wrong hello-world solution

2 participants