Skip to content

eslint-config-react-app should provide @babel/plugin-syntax-flow and @babel/plugin-transform-react-jsx #12456

Open
@quisido

Description

@quisido

Describe the bug

Installing eslint-config-react-app results in these two warnings:

➤ YN0002: │ eslint-config-react-app@npm:7.0.1 [41989] doesn't provide @babel/plugin-syntax-flow (pc2f30), requested by eslint-plugin-flowtype
➤ YN0002: │ eslint-config-react-app@npm:7.0.1 [41989] doesn't provide @babel/plugin-transform-react-jsx (p4cc0d), requested by eslint-plugin-flowtype

Environment

Yarn 3

Steps to reproduce

  1. yarn install

Expected behavior

eslint-config-react-app should correctly depend on @babel/plugin-syntax-flow and @babel/plugin-transform-react-jsx

Actual behavior

Warning


The fix for this is either too add @babel/plugin-syntax-flow and @babel/plugin-transform-react-jsx to the dependencies of eslint-config-react-app's package.json file or to its peerDependencies. I didn't know which is desired between the two (I assume peerDependencies, but I know ESLint can be finicky about nested dependencies), so I didn't want to cut a PR with the wrong change.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions