-
-
Notifications
You must be signed in to change notification settings - Fork 27.1k
Closed
Milestone
Description
Windows contributors have to deal with failing test cases due to line endings when comparing to snapshot tests.
See #3065 for reference.
We should create a .gitattributes
file which forces these files (all *.js files?) to be checked out with LF
line feeds.
Metadata
Metadata
Assignees
Type
Projects
Relationships
Development
Select code repository
Activity
duvet86 commentedon Sep 7, 2017
I can help with this, given that it affects me.
Cheers.
Timer commentedon Sep 7, 2017
Great, thanks!
ijajmulani commentedon Sep 13, 2017
Hi, looking to get involved in open source projects. If you want I can help you in this.
Fix for add .gitattributes file facebook#3080
ijajmulani commentedon Sep 13, 2017
Here is my PR for same.
duvet86 commentedon Sep 23, 2017
Unfortunately I can't find a way to normalise files using .gitattributes.
The only solution I've found is setting:
git config --global core.autocrlf false
As per stated here:
https://stackoverflow.com/questions/2517190/how-do-i-force-git-to-use-lf-instead-of-crlf-under-windows/13154031#13154031
Cheers Luca
Fix for add .gitattributes file #3080 (#3122)
Merge branch 'master' into serve-app-under
Merge branch 'master' of https://github.com/wmonk/create-react-app-ty…