Skip to content

ESLint warnings and errors ignored in npm run build #440

@mjomble

Description

@mjomble

To reproduce:

create-react-app cra-test
cd cra-test
echo foo() > src/index.js
npm start

Output:

Warning in ./src/index.js

E:\dev\cra-test\src\index.js
  1:1  warning  'foo' is not defined  no-undef

✖ 1 problem (0 errors, 1 warning)

But if you run npm run build:

Creating an optimized production build...
Compiled successfully.

File sizes after gzip:
...

Tested with 0.2.1

The reason is explained here:

to handle all errors and warnings with the node.js API you need to test err, stats.errors and stats.warnings

stats.errors and stats.warnings are checked in start.js but build.js only checks for err.

I may be able to submit a PR for this if needed.

Activity

gaearon

gaearon commented on Aug 14, 2016

@gaearon
Contributor

PR is welcome, I didn't really test this well.

gaearon

gaearon commented on Aug 14, 2016

@gaearon
Contributor

Do you think the build should fail?

mjomble

mjomble commented on Aug 14, 2016

@mjomble
Author

Maybe fail when there are errors and pass if there are only warnings?

gaearon

gaearon commented on Aug 14, 2016

@gaearon
Contributor

We have no errors in the lint config (on purpose). And we only use warnings for stuff that really hints at possible errors (i.e. no style rules). So I think it might be better to fail.

mjomble

mjomble commented on Aug 14, 2016

@mjomble
Author

Ah, that makes sense.

I also noticed that in start.js, if there are linting errors, the dev server starts up, but the "The app is running at..." message does not appear.
I might also change that in the PR, so that this message is always shown, whether there are linter warnings or not.

gaearon

gaearon commented on Aug 15, 2016

@gaearon
Contributor

Sounds good.

gaearon

gaearon commented on Feb 11, 2017

@gaearon
Contributor

I think this was fixed since.

locked and limited conversation to collaborators on Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @gaearon@mjomble

        Issue actions

          ESLint warnings and errors ignored in npm run build · Issue #440 · facebook/create-react-app