Skip to content

ESLint 4 #2735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaearon merged 5 commits into from
Jul 7, 2017
Merged

ESLint 4 #2735

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e19bbb1
Update eslint-loader 1.7.1 -> 1.9.0
trungdq88 Jul 6, 2017
02fa3fc
Add eslintPath option
trungdq88 Jul 6, 2017
4595eef
Update eslint 3.19.0 -> 4.1.1
trungdq88 Jul 6, 2017
9939836
Update peer dependencies
trungdq88 Jul 6, 2017
a37d5b4
Move eslintPath config to outside @remove-on-eject
trungdq88 Jul 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/eslint-config-react-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
],
"peerDependencies": {
"babel-eslint": "^7.2.3",
"eslint": "^3.19.0",
"eslint": "^4.1.1",
"eslint-plugin-flowtype": "^2.33.0",
"eslint-plugin-import": "^2.2.0",
"eslint-plugin-jsx-a11y": "^5.0.3",
Expand Down
1 change: 1 addition & 0 deletions packages/react-scripts/config/webpack.config.dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ module.exports = {
},
ignore: false,
useEslintrc: false,
eslintPath: require.resolve('eslint'),
Copy link
Copy Markdown
Contributor

@gaearon gaearon Jul 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably move this outside of @remove-on-eject.

// @remove-on-eject-end
},
loader: require.resolve('eslint-loader'),
Expand Down
1 change: 1 addition & 0 deletions packages/react-scripts/config/webpack.config.prod.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ module.exports = {
},
ignore: false,
useEslintrc: false,
eslintPath: require.resolve('eslint'),
Copy link
Copy Markdown
Contributor

@gaearon gaearon Jul 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

// @remove-on-eject-end
},
loader: require.resolve('eslint-loader'),
Expand Down
8 changes: 4 additions & 4 deletions packages/react-scripts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@
"chalk": "1.1.3",
"css-loader": "0.28.4",
"dotenv": "4.0.0",
"eslint": "3.19.0",
"eslint": "4.1.1",
"eslint-config-react-app": "^1.0.5",
"eslint-loader": "1.7.1",
"eslint-loader": "1.9.0",
"eslint-plugin-flowtype": "2.34.0",
"eslint-plugin-import": "2.2.0",
"eslint-plugin-jsx-a11y": "5.0.3",
"eslint-plugin-import": "2.7.0",
"eslint-plugin-jsx-a11y": "5.1.1",
"eslint-plugin-react": "7.1.0",
"extract-text-webpack-plugin": "2.1.2",
"file-loader": "0.11.2",
Expand Down