Add environment variable to control image inlining threshold

[peterbe]

Fixes #3437

I verified that this worked by editing the default application (packages/react-scripts/template/src/App.js) to reference a logo.png image that I made up. The file was 5,237 bytes and when I ran yarn run build the build/static/js/main.8204aa3b.chunk.js did contain the base64 string. Then, running IMAGE_INLINE_SIZE_LIMIT=5000 yarn run build this time the build/static/js/main.499ec856.chunk.js file was -5.27KB and the file build/static/media/logo.adb700a2.png existed.

[peterbe]

Can someone guide me in what's wrong with those two failing Travis builds?

[peterbe]

@Timer apart from the conflict, which I can fix, can you help me with the failing Travis test and a review?

[stale]

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

[stale]

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

[rohan-deshpande]

I need this functionality, but the other way round, ie., I want everything to be base64 encoded.

Would be good to see this get merged. Seems like the issues are arising due to a missing module?

Error: [BABEL] /tmp/tmp.74WMXrb0ri/test-app-typescript/src/index.tsx: Cannot find module '@babel/plugin-transform-react-jsx-source' (While processing: "/tmp/tmp.74WMXrb0ri/test-app-typescript/node_modules/babel-preset-react-app/index.js$1")

[Rogdham]

The corresponding issue #3437 has got some traction in the meanwhile, with different people saying that it is quite an issue for them due to CSP blocking data:, and that they would like this PR to be merged.

@iansu I see you assigned yourself on this PR a while ago. Could you please tell us how we should proceed for this PR to be merged? What are the required steps? 🙏

[ianschmitz]

Thanks @peterbe!