Skip to content

Suggests that tsconfig.json is incorrect only when SyntaxError is caught #6160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iansu merged 3 commits into from
Apr 4, 2019
Merged

Suggests that tsconfig.json is incorrect only when SyntaxError is caught #6160

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cec8f0d
Suggests that tsconfig.json is incorrect only when SyntaxError is caught
Andarist Jan 9, 2019
322b289
Update verifyTypeScriptSetup.js
iansu Apr 3, 2019
fb6b629
Update verifyTypeScriptSetup.js
iansu Apr 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,13 +172,16 @@ function verifyTypeScriptSetup() {

parsedCompilerOptions = result.options;
} catch (e) {
console.error(
chalk.red.bold(
'Could not parse',
chalk.cyan('tsconfig.json') + '.',
'Please make sure it contains syntactically correct JSON.'
)
);
if (e && e.name === 'SyntaxError') {
console.error(
chalk.red.bold(
'Could not parse',
chalk.cyan('tsconfig.json') + '.',
'Please make sure it contains syntactically correct JSON.'
)
);
}

console.error(e && e.message ? `Details: ${e.message}` : '');
Copy link
Copy Markdown
Contributor

@iansu iansu Mar 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop "Details: " from the start of the error message because it doesn't really make sense in the case of non-syntax error.

process.exit(1);
}
Expand Down