change NODE_ENV and PUBLIC_URL into readonly#6750
Merged
mrmckeb merged 1 commit intofacebook:masterfrom Apr 7, 2019
xiaoxiangmoe:master
Merged
change NODE_ENV and PUBLIC_URL into readonly#6750mrmckeb merged 1 commit intofacebook:masterfrom xiaoxiangmoe:master
mrmckeb merged 1 commit intofacebook:masterfrom
xiaoxiangmoe:master
Conversation
xiaoxiangmoe
requested review from
Timer,
amyrlam,
bugzpodder,
gaearon,
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
mrmckeb
approved these changes
Apr 7, 2019
Contributor
mrmckeb
left a comment
mrmckeb
left a comment
There was a problem hiding this comment.
Great idea, @xiaoxiangmoe. Let's get this one in!
Contributor
|
@xiaoxiangmoe - can you please rebase from master and see if that fixes your tests, I'm assuming it will. I know the tests failures are unrelated, but I think we should make sure they're passing regardless. |
ianschmitz
approved these changes
Apr 7, 2019
Contributor
|
Thanks again, @xiaoxiangmoe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
after change it
will throw