Call to action button now "reacts" to being hovered :)#6810
Call to action button now "reacts" to being hovered :)#6810amyrlam merged 4 commits intofacebook:masterfrom
Conversation
Slight scale up on the get started button upon hover.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
1 similar comment
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
It's strange there is no change on hover! Maybe we should go with a simpler fix - perhaps a color change, for us turn white on hover - similar to https://docusaurus.io/ or https://sorbet.org/. That would also match the styling of the edit button on https://facebook.github.io/create-react-app/docs/getting-started. What do you think? |
I think that's a good idea! |
|
@amyrlam That change has been made. |
amyrlam
left a comment
amyrlam
left a comment
There was a problem hiding this comment.
Made a couple suggestions, let me know.
Thanks for making the changes! 👍
Co-Authored-By: joerez <rezenbiz@gmail.com>
Co-Authored-By: joerez <rezenbiz@gmail.com>
|
Nit is good. Suggestions added. |
3 participants
Added a slight scale up on the get started button upon hover.