Remove Object.assign from MiniCssExtractPlugin options#6854
Merged
iansu merged 1 commit intofacebook:masterfrom Apr 29, 2019
Merged
Remove Object.assign from MiniCssExtractPlugin options#6854iansu merged 1 commit intofacebook:masterfrom
Object.assign from MiniCssExtractPlugin options#6854iansu merged 1 commit intofacebook:masterfrom
Conversation
swashcap
requested review from
Timer,
amyrlam,
bugzpodder,
gaearon,
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
Timer
approved these changes
Apr 29, 2019
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Hello! I'm reading through react-scripts' Webpack configuration to learn a little bit more about Webpack. Thanks for the ample comments! It's super helpful.
I noticed this unneeded
Object.assignin a.cssloader's options, so thought I'd remove it.Object.assigninshouldUseRelativeAssetPathsfalsey case adds a lil bit of an unneeded function callObject.assignand add{}to the ternary false expression