Fix no-useless-constructor rule in TypeScript#6862
Merged
ianschmitz merged 1 commit intofacebook:masterfrom Apr 24, 2019
Merged
Fix no-useless-constructor rule in TypeScript#6862ianschmitz merged 1 commit intofacebook:masterfrom
ianschmitz merged 1 commit intofacebook:masterfrom
Conversation
Contributor
|
I might be reading this wrong but doesn't this just disable the rule? Will things like constructor(props: MyProps) {
super(props);
}Still get reported as they IMO should? |
Contributor
Author
|
This turns off the ESLint rule for typescript files in favor of the typescript-eslint equivalent rule |
iansu
approved these changes
Apr 23, 2019
mrmckeb
reviewed
Apr 24, 2019
Contributor
mrmckeb
left a comment
There was a problem hiding this comment.
I also see:
camelcase: 'off',
indent: 'off',I'm OK with removing those, but just wanted to ensure that was deliberate.
Contributor
Author
|
@mrmckeb yes that was intentional. I originally had copied that in from the recommended preset of typescript-eslint, but we don't have either of those ESLint rules enabled so they're not needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6861.