Skip to content

Add clarifying note to TypeScript docs warning about global install of CRA#6945

Merged
amyrlam merged 2 commits intofacebook:masterfrom
methodbox:amend-docs-adding-typescript
May 1, 2019
Merged

Add clarifying note to TypeScript docs warning about global install of CRA#6945
amyrlam merged 2 commits intofacebook:masterfrom
methodbox:amend-docs-adding-typescript

Conversation

@methodbox
Copy link
Copy Markdown
Contributor

Added block quote with warning about issues when CRA is installed globally.

Related to: #6816 & #6911

Updating blockquote to advise on use of CRA globally vs. npx when using --typescript flag.

Added block quote with warning about issues when CRA is installed globally.
@amyrlam amyrlam added this to the 3.0.1 milestone Apr 28, 2019
@amyrlam amyrlam changed the title amend-docs-adding-typescript Add clarifying note to TypeScript docs warning about global install of CRA Apr 28, 2019
Co-Authored-By: methodbox <chris@methodbox.io>
Copy link
Copy Markdown
Contributor

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing your fork and resubmitting! 🎉 Looks good to me, will let @iansu confirm.

@amyrlam amyrlam merged commit 6710f52 into facebook:master May 1, 2019
@amyrlam
Copy link
Copy Markdown
Contributor

amyrlam commented May 1, 2019

I reworded the title too long with the PR number amended to end (#6945), will account for that in commit length next time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants