Merged
Conversation
…sk script; other cleanup (#5)
….npmjs.org; simplify YAML
Restore --skip-git override default checkout directory
Azure Pipelines support (Linux, macOS, and Windows)
Cleanup DevOps
ianschmitz
requested review from
amyrlam,
bugzpodder,
gaearon,
iansu,
mrmckeb and
petetnt
as code owners
Contributor
|
Should we test on Node 12 too now that it is out? |
Contributor
|
@petetnt Do the tests actually pass on Node 12? We should start working on getting everything working on Node 12 because people are already using it. It won't be LTS until October but we definitely want to have it working before then. That's going to add something like 11 more checks though. 😬 |
Contributor
|
@iansu haven't tested yet myself, but I did see that there were some issues with CRA / its dependencies on Node@12 at some point IIRC |
iansu
reviewed
May 26, 2019
ianschmitz
changed the title
This was referenced May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support to run our CI builds using Azure DevOps. Huge thanks to @willsmythe and others at Microsoft for their help getting us moved over.
TODO:
Create issues in Verdaccio (Azure Pipelines support (Linux, macOS, and Windows) ianschmitz/create-react-app#2)- Uplink connection timeout returns incorrect status code verdaccio/verdaccio#1328 Expose HTTP Agent options verdaccio/verdaccio#1329Create follow up issue in this project to track above Verdaccio issue once created- Update Verdaccio #7129Create issue to track status of Pipeline caching in DevOps (sounds like should be available in June/July timeline as a preview - Proposals/pipeline caching microsoft/azure-pipelines-yaml#113)Add caching to DevOps pipeline #7128